chore(F6.1): run targeted cancellation UX patch
This commit is contained in:
@@ -3,9 +3,9 @@ name: F6.1 apply cancellation UX
|
|||||||
on:
|
on:
|
||||||
push:
|
push:
|
||||||
branches:
|
branches:
|
||||||
- 'hotfix/f6-1-operator-cancel-ux'
|
- hotfix/f6-1-operator-cancel-ux
|
||||||
paths:
|
paths:
|
||||||
- '.github/workflows/f6-1-apply-cancel-ux.yml'
|
- .github/workflows/f6-1-apply-cancel-ux.yml
|
||||||
|
|
||||||
permissions:
|
permissions:
|
||||||
contents: write
|
contents: write
|
||||||
@@ -18,96 +18,14 @@ jobs:
|
|||||||
with:
|
with:
|
||||||
ref: hotfix/f6-1-operator-cancel-ux
|
ref: hotfix/f6-1-operator-cancel-ux
|
||||||
fetch-depth: 0
|
fetch-depth: 0
|
||||||
|
- name: Apply targeted patch
|
||||||
- name: Replace prompt cancellation with explicit audited form
|
run: python scripts/f6-1-apply-cancel-ux.py
|
||||||
run: |
|
|
||||||
python - <<'PY'
|
|
||||||
from pathlib import Path
|
|
||||||
import re
|
|
||||||
|
|
||||||
path = Path('web-v2/src/pages/InspectionVisitEditorF4Page.tsx')
|
|
||||||
text = path.read_text()
|
|
||||||
|
|
||||||
state_before = " const [success, setSuccess] = useState('');\n"
|
|
||||||
state_after = """ const [success, setSuccess] = useState('');
|
|
||||||
const [showCancelForm, setShowCancelForm] = useState(false);
|
|
||||||
const [cancelReason, setCancelReason] = useState('');
|
|
||||||
"""
|
|
||||||
if text.count(state_before) != 1:
|
|
||||||
raise SystemExit('Could not locate success state exactly once')
|
|
||||||
text = text.replace(state_before, state_after)
|
|
||||||
|
|
||||||
lifecycle_pattern = re.compile(
|
|
||||||
r" const lifecycleAction = async \(action: 'PLAN' \| 'UNPLAN' \| 'CANCEL'\) => \{.*?\n \};\n\n if \(loading\)",
|
|
||||||
re.S,
|
|
||||||
)
|
|
||||||
lifecycle_replacement = """ const lifecycleAction = async (action: 'PLAN' | 'UNPLAN') => {
|
|
||||||
if (!id) return;
|
|
||||||
setBusy(true); setError(''); setSuccess('');
|
|
||||||
try {
|
|
||||||
let updated: InspectionVisit;
|
|
||||||
if (action === 'PLAN') {
|
|
||||||
updated = await planInspectionVisit(id);
|
|
||||||
setSuccess('Inspección planificada. Ya puede iniciarse desde la APK.');
|
|
||||||
} else {
|
|
||||||
updated = await unplanInspectionVisit(id);
|
|
||||||
setSuccess('La Inspección volvió a borrador para corregir la planificación.');
|
|
||||||
}
|
|
||||||
applyVisit(updated);
|
|
||||||
} catch (requestError) { setError(errorMessage(requestError)); }
|
|
||||||
finally { setBusy(false); }
|
|
||||||
};
|
|
||||||
|
|
||||||
const cancelCurrentVisit = async (event: FormEvent) => {
|
|
||||||
event.preventDefault();
|
|
||||||
if (!id) return;
|
|
||||||
const reason = cancelReason.trim();
|
|
||||||
if (reason.length < 10) {
|
|
||||||
setError('El motivo de cancelación debe tener al menos 10 caracteres.');
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
if (reason.length > 500) {
|
|
||||||
setError('El motivo de cancelación no puede superar los 500 caracteres.');
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
setBusy(true); setError(''); setSuccess('');
|
|
||||||
try {
|
|
||||||
const updated = await cancelInspectionVisit(id, reason);
|
|
||||||
applyVisit(updated);
|
|
||||||
setCancelReason('');
|
|
||||||
setShowCancelForm(false);
|
|
||||||
setSuccess('Inspección cancelada. El motivo quedó registrado y auditado.');
|
|
||||||
} catch (requestError) { setError(errorMessage(requestError)); }
|
|
||||||
finally { setBusy(false); }
|
|
||||||
};
|
|
||||||
|
|
||||||
if (loading)"""
|
|
||||||
text, count = lifecycle_pattern.subn(lifecycle_replacement, text, count=1)
|
|
||||||
if count != 1:
|
|
||||||
raise SystemExit(f'Lifecycle block replacements: {count}')
|
|
||||||
|
|
||||||
actions_pattern = re.compile(
|
|
||||||
r" \{visit && <article className=\"panel survey-status-actions\">.*?</article>\}\n",
|
|
||||||
re.S,
|
|
||||||
)
|
|
||||||
actions_replacement = """ {visit && <article className=\"panel survey-status-actions\"><div><strong>Flujo de la Inspección</strong><p>La oficina planifica. El inicio y cierre operativo se realizan desde la APK. Una Inspección no puede cerrarse hasta que todas sus Actas estén selladas.</p></div><div className=\"form-actions\">{canManage && visit.status === 'DRAFT' && <button type=\"button\" className=\"button primary\" disabled={busy} onClick={() => void lifecycleAction('PLAN')}>Confirmar planificación</button>}{canManage && visit.status === 'PLANNED' && <button type=\"button\" className=\"button secondary\" disabled={busy} onClick={() => void lifecycleAction('UNPLAN')}>Volver a borrador</button>}{canManage && ['DRAFT', 'PLANNED', 'IN_PROGRESS'].includes(visit.status) && <button type=\"button\" className=\"button danger-outline\" disabled={busy} onClick={() => { setError(''); setSuccess(''); setShowCancelForm(true); }}>Cancelar inspección</button>}</div></article>}
|
|
||||||
|
|
||||||
{visit && showCancelForm && ['DRAFT', 'PLANNED', 'IN_PROGRESS'].includes(visit.status) && <form className=\"panel form-panel\" onSubmit={cancelCurrentVisit}><div className=\"panel-heading\"><div><span className=\"eyebrow\">CANCELACIÓN</span><h2>Cancelar inspección</h2><p className=\"section-copy\">La cancelación es definitiva y queda auditada. No se permite si la Inspección ya tiene un Acta sellada.</p></div></div><label className=\"field\"><span>Motivo de cancelación</span><textarea value={cancelReason} onChange={(event) => setCancelReason(event.target.value)} minLength={10} maxLength={500} rows={4} placeholder=\"Explicá el motivo de la cancelación…\" required /><small className=\"muted\">{cancelReason.trim().length}/500 · mínimo 10 caracteres</small></label><div className=\"form-actions\"><button type=\"button\" className=\"button secondary\" disabled={busy} onClick={() => { setShowCancelForm(false); setCancelReason(''); }}>Volver</button><button type=\"submit\" className=\"button danger-outline\" disabled={busy || cancelReason.trim().length < 10 || cancelReason.trim().length > 500}>{busy ? 'Cancelando…' : 'Confirmar cancelación'}</button></div></form>}
|
|
||||||
"""
|
|
||||||
text, count = actions_pattern.subn(actions_replacement, text, count=1)
|
|
||||||
if count != 1:
|
|
||||||
raise SystemExit(f'Actions block replacements: {count}')
|
|
||||||
|
|
||||||
path.write_text(text)
|
|
||||||
Path('.github/workflows/f6-1-apply-cancel-ux.yml').unlink()
|
|
||||||
PY
|
|
||||||
|
|
||||||
- name: Commit cancellation UX
|
- name: Commit cancellation UX
|
||||||
run: |
|
run: |
|
||||||
set -Eeuo pipefail
|
rm .github/workflows/f6-1-apply-cancel-ux.yml scripts/f6-1-apply-cancel-ux.py
|
||||||
git config user.name 'github-actions[bot]'
|
git config user.name 'github-actions[bot]'
|
||||||
git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
|
git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
|
||||||
git add web-v2/src/pages/InspectionVisitEditorF4Page.tsx .github/workflows/f6-1-apply-cancel-ux.yml
|
git add web-v2/src/pages/InspectionVisitEditorF4Page.tsx .github/workflows/f6-1-apply-cancel-ux.yml scripts/f6-1-apply-cancel-ux.py
|
||||||
git diff --cached --check
|
git diff --cached --check
|
||||||
git commit -m 'fix(F6.1): add explicit audited inspection cancellation form'
|
git commit -m 'fix(F6.1): add explicit audited inspection cancellation form'
|
||||||
git push origin HEAD:hotfix/f6-1-operator-cancel-ux
|
git push origin HEAD:hotfix/f6-1-operator-cancel-ux
|
||||||
|
|||||||
Reference in New Issue
Block a user