fix(field): repair finding creation and simplify mobile UX

api-v3/src/database/migrations/1790121000000-f6-5-field-finding-code-contract.ts

@@ -0,0 +1,45 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+/**
+ * F4 cambió el código visible del Acta a ACT-NNNNN-DD-MM-YY, pero el CHECK
+ * histórico de Hallazgos seguía aceptando sólo ACTA-YYYY-NNNNNN-HNNN.
+ * El servicio genera el Hallazgo a partir del código real del Acta, por lo que
+ * PostgreSQL rechazaba altas válidas de campo con un 500.
+ */
+export class F65FieldFindingCodeContract1790121000000 implements MigrationInterface {
+  name = 'F65FieldFindingCodeContract1790121000000';
+
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+      ALTER TABLE inspection_findings
+      DROP CONSTRAINT IF EXISTS chk_inspection_findings_code
+    `);
+    await queryRunner.query(`
+      ALTER TABLE inspection_findings
+      ADD CONSTRAINT chk_inspection_findings_code CHECK (
+        code ~ '^(ACTA-[0-9]{4}-[0-9]{6}|ACT-[0-9]{5}-[0-9]{2}-[0-9]{2}-[0-9]{2})-H[0-9]{3}$'
+      )
+    `);
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+      UPDATE inspection_findings finding
+      SET code = 'ACTA-' || act.act_year::text || '-' || LPAD(act.act_number::text, 6, '0')
+        || '-H' || LPAD(finding.finding_number::text, 3, '0')
+      FROM inspection_acts act
+      WHERE finding.act_id = act.id
+        AND finding.code ~ '^ACT-[0-9]{5}-[0-9]{2}-[0-9]{2}-[0-9]{2}-H[0-9]{3}$'
+    `);
+    await queryRunner.query(`
+      ALTER TABLE inspection_findings
+      DROP CONSTRAINT IF EXISTS chk_inspection_findings_code
+    `);
+    await queryRunner.query(`
+      ALTER TABLE inspection_findings
+      ADD CONSTRAINT chk_inspection_findings_code CHECK (
+        code ~ '^ACTA-[0-9]{4}-[0-9]{6}-H[0-9]{3}$'
+      )
+    `);
+  }
+}

api-v3/src/inspection-visits/dto/create-field-finding.dto.ts

@@ -4,7 +4,6 @@ import {
   IsOptional,
   IsString,
   IsUUID,
-  Matches,
   Max,
   MaxLength,
   Min,
@@ -56,8 +55,4 @@ export class CreateFieldFindingDto {
   @Max(10)
   severity?: number;
 
-  @IsOptional()
-  @Transform(optionalText)
-  @Matches(/^\d{4}-\d{2}-\d{2}$/)
-  correctionDueOn?: string | null;
 }

api-v3/src/inspection-visits/field-findings.service.ts

@@ -105,7 +105,7 @@ export class FieldFindingsService {
       customLegalBasis: dto.customLegalBasis ?? null,
       description: dto.description,
       severity: dto.severity,
-      correctionDueOn: dto.correctionDueOn ?? null,
+      correctionDueOn: null,
     };
     const finding = await this.findings.create(act.id, payload, principal, request);
     return {

api-v3/src/version.ts

@@ -1,2 +1,2 @@
-export const API_VERSION = '0.29.0-4';
+export const API_VERSION = '0.29.0-5';
 export const API_PHASE = 'F6.2';