admin/dh-inspeccion-v2
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 3 Wiki Activity

fix: decouple act locking from visit verification completion

Browse Source
This commit is contained in:
admin
2026-09-08 09:07:05 -03:00
parent 2506bece76
commit 71d0884557
1 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api-v3/src/inspection-closing/inspection-closing.service.ts
-17
View File
@@ -277,7 +277,6 @@ export class InspectionClosingService {
this.assertDraftInProgress(act, visit); this.assertDraftInProgress(act, visit);
await this.assertActorAssigned(manager, visit.id, principal, true); await this.assertActorAssigned(manager, visit.id, principal, true);
await this.requireResponsible(manager, actId); await this.requireResponsible(manager, actId);
await this.assertVerificationResultsComplete(manager, visit.id);
if (await this.signatureCount(manager, actId)) { if (await this.signatureCount(manager, actId)) {
throw new ConflictException({ throw new ConflictException({
code: 'INSPECTION_ACT_ALREADY_SIGNED', code: 'INSPECTION_ACT_ALREADY_SIGNED',
@@ -935,22 +934,6 @@ export class InspectionClosingService {
}; };
} }
private async assertVerificationResultsComplete(manager: EntityManager, inspectionId: string): Promise<void> {
const [row] = await manager.query(`
SELECT
COUNT(*)::integer AS total,
COUNT(*) FILTER (WHERE outcome IS NOT NULL)::integer AS completed
FROM inspection_finding_verification_visits
WHERE visit_id=$1
`, [inspectionId]) as Array<{ total: number; completed: number }>;
if (Number(row?.total ?? 0) > 0 && Number(row.completed) !== Number(row.total)) {
throw new ConflictException({
code: 'INSPECTION_VERIFICATION_RESULTS_REQUIRED',
message: 'Registrá el resultado de todas las verificaciones antes de finalizar el acta',
});
}
}
private async deadlinePolicy(manager: EntityManager): Promise<DeadlinePolicy> { private async deadlinePolicy(manager: EntityManager): Promise<DeadlinePolicy> {
const [row] = await manager.query(` const [row] = await manager.query(`
SELECT SELECT